Add TVD Loss Kernel #324
Open
Add TVD Loss Kernel #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ByronHsu @qingquansong @lancerts Please let me know if any changes are required. |
Open
yundai424
reviewed
Nov 8, 2024
test/transformers/test_tvd.py
Outdated
| pytest.param( | ||
| torch.bfloat16, | ||
| 1e-8, | ||
| 5e-2, |
There was a problem hiding this comment.
could you help to experiment what is the lowest rtol that will not fail this test for bf16? Thanks!
There was a problem hiding this comment.
@yundai424 Please ignore previous comment. 1e-6 is the lowest rtol which is not failing.
qingquansong
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Thanks for the efforts! Could you also add this to the init function in transformers folder as well same as JSD? https://github.com/linkedin/Liger-Kernel/blob/main/src/liger_kernel/transformers/__init__.py#L10
Tcc0403
reviewed
Nov 8, 2024
|
@yundai424 @Tcc0403 @qingquansong @ByronHsu I have made the changes as per the comments. Let me know if any further changes are required. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #281. Implements the TVD (Total Variation Distance) kernel by computing both the loss and gradient in the forward pass.
Testing Done
Implemented tests to verify that the results of the forward and backward passes match the Torch implementation. Additionally, added a script to benchmark the memory usage and speed of the Liger implementation compared to Torch, with the results shown below.
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence