Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qwen2 import failure in test #394

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix qwen2 import failure in test #394

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
359a445
fix qwen2 import failure in test
ByronHsu Nov 19, 2024
8824c63
fix
ByronHsu Nov 19, 2024
8d6d0b3
style
ByronHsu Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions test/transformers/test_qwen2vl_mrope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,25 @@

import pytest
import torch
from transformers.models.qwen2_vl.modeling_qwen2_vl import (
Qwen2VLRotaryEmbedding,
apply_multimodal_rotary_pos_emb,
)

try:
from transformers.models.qwen2_vl.modeling_qwen2_vl import (
Qwen2VLRotaryEmbedding,
apply_multimodal_rotary_pos_emb,
)

IS_QWEN_AVAILABLE = True
except Exception:
IS_QWEN_AVAILABLE = False

from liger_kernel.ops.qwen2vl_mrope import LigerQwen2VLMRopeFunction
from liger_kernel.transformers.functional import liger_qwen2vl_mrope
from liger_kernel.transformers.qwen2vl_mrope import liger_multimodal_rotary_pos_emb


@pytest.mark.skipif(
not IS_QWEN_AVAILABLE, reason="Qwen is not available in transformers."
)
@pytest.mark.parametrize("bsz", [1, 2])
@pytest.mark.parametrize("seq_len", [128, 131])
@pytest.mark.parametrize("num_q_heads, num_kv_heads", [(64, 8), (28, 4), (12, 2)])
Expand Down Expand Up @@ -87,6 +96,9 @@ def test_correctness(
torch.testing.assert_close(k1_grad, k2_grad, atol=atol, rtol=rtol)


@pytest.mark.skipif(
not IS_QWEN_AVAILABLE, reason="Qwen is not available in transformers."
)
@pytest.mark.parametrize(
"bsz, seq_len, num_q_heads, num_kv_heads, head_dim, mrope_section",
[
Expand Down
Loading