Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #411
The convergence tests all passed in the latest commit (PR#407). Its CI worked fine: https://github.com/linkedin/Liger-Kernel/actions/runs/11983838113/job/33413899589?pr=407#step:5:984
Without any code changes inside Liger, the convergence tests now failed in QWEN2VL cases, referring to QWEN2 VL doesn't converge #411.
The root cause of this issue lies in HuggingFace's release of new transformers, which introduced modifications to QWEN2VL. Since the discrepancy doesn't originate from a bug in the Liger QWEN2VL implementation, it's acceptable to slightly relax the relative tolerances (
rtols
) to accommodate these changes.By the way, it seems there might be some related context:
Liger-Kernel/test/convergence/test_mini_models.py
Line 530 in 0137757
Testing Done
Yes.
Full log below,
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence