Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_batch_loss_metrics comments #413

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix get_batch_loss_metrics comments #413

merged 1 commit into from
Nov 28, 2024

Conversation

austin362667
Copy link
Collaborator

Summary

Remove misleading docstring in get_batch_loss_metrics() of test/utils.py.

Testing Done

  • Hardware Type: A10G
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@austin362667
Fix docs
5850ff8 
Signed-off-by: Austin Liu <austin362667@gmail.com>
@ByronHsu ByronHsu merged commit 0137757 into linkedin:main Nov 28, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austin362667 @ByronHsu