Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve code quality for chunk loss #448

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

ByronHsu
Copy link
Collaborator

@ByronHsu ByronHsu commented Dec 9, 2024

Summary

  1. Rename var / func
  2. Move input grad accumulation from the for loop into the accum helper
  3. Move forward to the top
  4. Add some explanatory comments

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@ByronHsu ByronHsu merged commit 24bdb2c into main Dec 9, 2024
5 checks passed
@ByronHsu ByronHsu deleted the byhsu/improve-chunk-loss branch December 9, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant