Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify ref_input in chunked_loss base class and fix tests #470

Merged
merged 4 commits into from
Dec 12, 2024
Merged

modify ref_input in chunked_loss base class and fix tests #470

merged 4 commits into from
Dec 12, 2024

Conversation

shivam15s
Copy link
Collaborator

@shivam15s shivam15s commented Dec 11, 2024 •
edited
Loading

Summary

modify ref_input in pref_loss and pass tests. Aims to fix #447

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@shivam15s shivam15s changed the title modify ref_input in pref_loss and pass tests modify ref_input in chunked_loss base class and fix tests Dec 11, 2024
@ByronHsu ByronHsu enabled auto-merge (squash) December 12, 2024 03:38
@ByronHsu ByronHsu disabled auto-merge December 12, 2024 03:39
@ByronHsu ByronHsu merged commit 55e3755 into main Dec 12, 2024
5 checks passed
@ByronHsu ByronHsu deleted the shisahni/dpo_ref_input branch December 12, 2024 03:39
hebiao064
hebiao064 reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@hebiao064 hebiao064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/linkedin/Liger-Kernel/pull/470/files#diff-3048cb37b97e27515852c200994f3257b8ae33a465421d05184713377c0895b1R20-R23

The docstring is not right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebiao064 hebiao064 hebiao064 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference model bug (no way to input ref_inputs)
3 participants
@shivam15s @hebiao064 @ByronHsu