Fix Unit Test error brought by Transformer Breaking Changes #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronHsu
previously approved these changes
Jan 15, 2025
|
@hebiao064 can you make a condition for tests-bwd to pass with older transformers version? Some users are on older transformers version Something like |
Make sense, added |
Comment on lines
+117
to
+122
| if transformers_version < "4.48.0": | ||
| # LlamaRotaryEmbedding constructor signature changed in transformers 4.48.0 | ||
| rotary_emb = LlamaRotaryEmbedding(head_dim, device=device) | ||
| else: | ||
| llama_config = LlamaConfig(head_dim=head_dim) | ||
| rotary_emb = LlamaRotaryEmbedding(llama_config, device=device) |
There was a problem hiding this comment.
seems like we are repeating same code in all places. Shall we prepare a common function to get the rotary embeddings?
There was a problem hiding this comment.
hey @kvignesh1420 thanks for the great advice, I added a more general helper function here: #526.
3 tasks
austin362667
added a commit
that referenced
this pull request
Jan 20, 2025
## Summary 1. Add a general `version_dispatch` utility function that selects constructors and its args based on version comparisons. 2. Update `LlamaRotaryEmbedding`. Closes Issue #525 and PR #523 (Thanks to @hebiao064's nice works). ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [X] run `make test` to ensure correctness - [X] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence --------- Signed-off-by: Austin Liu <austin362667@gmail.com>
|
Close as it was finished in #526 |
auto-merge was automatically disabled
January 20, 2025 03:03
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a breaking changes from HF Transformers that will break out unit test:
https://github.com/huggingface/transformers/blame/137965ca7d0b453b22806c0a5fffc51fde821c33/src/transformers/models/llama/modeling_llama.py#L85
For example, it broke my PR about KTO Loss which has nothing to do with
FAILED test/transformers/test_rope.py::test_correctnesshttps://github.com/linkedin/Liger-Kernel/actions/runs/12779518445/job/35624270834?pr=475
Testing Done
Unit Test is done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence