Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more error message to help debug invalid offset #1160

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

jsjtzyy
Copy link
Contributor

@jsjtzyy jsjtzyy commented Apr 25, 2019

Added logSegment info into exception message to help investigate
potential race condition during compaction.

Added logSegment info into exception message to help investigate
potential race condition during compaction.
@jsjtzyy jsjtzyy requested a review from zzmao April 25, 2019 23:54
@jsjtzyy jsjtzyy self-assigned this Apr 25, 2019
@codecov-io
Copy link

Codecov Report

Merging #1160 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1160      +/-   ##
============================================
- Coverage     69.81%   69.76%   -0.05%     
+ Complexity     5312     5308       -4     
============================================
  Files           420      420              
  Lines         32547    32547              
  Branches       4139     4139              
============================================
- Hits          22722    22706      -16     
- Misses         8698     8709      +11     
- Partials       1127     1132       +5
Impacted Files Coverage Δ Complexity Δ
...n/java/com.github.ambry.store/PersistentIndex.java 92.11% <100%> (ø) 196 <0> (ø) ⬇️
...github.ambry.rest/AsyncRequestResponseHandler.java 88.59% <0%> (-2.29%) 23% <0%> (ø)
...b.ambry.network/BlockingChannelConnectionPool.java 70.17% <0%> (-1.76%) 9% <0%> (ø)
...in/java/com.github.ambry.store/BlobStoreStats.java 70.92% <0%> (-1.65%) 103% <0%> (-2%)
.../main/java/com.github.ambry.store/ScanResults.java 81.25% <0%> (-1.57%) 16% <0%> (-1%)
.../java/com.github.ambry.router/DeleteOperation.java 92.19% <0%> (-1.42%) 47% <0%> (-1%)
.../com.github.ambry.router/GetBlobInfoOperation.java 83.52% <0%> (-1.14%) 39% <0%> (-1%)
...java/com.github.ambry.network/SSLTransmission.java 69.1% <0%> (-0.64%) 67% <0%> (-2%)
...ain/java/com.github.ambry.router/PutOperation.java 91.39% <0%> (+0.35%) 108% <0%> (+1%) ⬆️
...src/main/java/com.github.ambry.commons/BlobId.java 93.54% <0%> (+0.35%) 72% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f3c2e...7c722ec. Read the comment docs.

@zzmao zzmao merged commit 57fe69b into linkedin:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants