Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helix test issues. #1177

Merged
merged 2 commits into from
Jun 1, 2019
Merged

Fix helix test issues. #1177

merged 2 commits into from
Jun 1, 2019

Conversation

zzmao
Copy link
Contributor

@zzmao zzmao commented May 31, 2019

Increate timeout threshold for helix balance verifier.
Add onBecomeDroppedFromOffline in HelixVcrStateModel.

@zzmao zzmao requested a review from jsjtzyy May 31, 2019 23:57
@jsjtzyy jsjtzyy merged commit ea57d81 into linkedin:master Jun 1, 2019
@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #1177 into master will decrease coverage by 0.07%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1177      +/-   ##
============================================
- Coverage     69.86%   69.79%   -0.08%     
+ Complexity     5374     5370       -4     
============================================
  Files           428      428              
  Lines         32863    32865       +2     
  Branches       4147     4147              
============================================
- Hits          22960    22938      -22     
- Misses         8772     8789      +17     
- Partials       1131     1138       +7
Impacted Files Coverage Δ Complexity Δ
...ava/com.github.ambry.cloud/HelixVcrStateModel.java 61.53% <0%> (-8.03%) 5 <0> (ø)
...rc/main/java/com.github.ambry.cloud/VcrServer.java 76.34% <50%> (+0.81%) 4 <0> (ø) ⬇️
...c/main/java/com.github.ambry.network/Selector.java 77.22% <0%> (-3.48%) 47% <0%> (-1%)
...github.ambry.rest/AsyncRequestResponseHandler.java 88.59% <0%> (-2.29%) 23% <0%> (ø)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.13% <0%> (-0.62%) 103% <0%> (ø)
...va/com.github.ambry.replication/ReplicaThread.java 74.15% <0%> (-0.57%) 64% <0%> (-2%)
...java/com.github.ambry.network/SSLTransmission.java 69.42% <0%> (-0.32%) 68% <0%> (-1%)
...in/java/com.github.ambry.network/SocketServer.java 84.01% <0%> (+0.4%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6373104...953c501. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants