-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use customized blobId string as Azure blob name. #1181
Conversation
Add blobUploadTotalByteRate and blobUploadTotalLatency to AzureMetrics.
@@ -41,7 +42,8 @@ | |||
public static final String BLOB_DELETION_TIME = "BlobDeletionTime"; | |||
public static final String BLOB_DELETE_ERROR_COUNT = "BlobDeleteErrorCount"; | |||
public static final String CONFIG_ERROR_COUNT = "ConfigErrorCount"; | |||
public static final String BLOB_UPLOAD_RATE = "BlobUploadRate"; | |||
public static final String BLOB_UPLOAD_TOTAL_BYTE_RATE = "BlobUploadTotalByteRate"; | |||
public static final String BLOB_UPLOAD_TOTAL_LATENCY = "BlobUploadTotalLatency"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latency can be translated to two graph one is meter and the other is timer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but see question about histogram metric.
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureMetrics.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureMetrics.java
Outdated
Show resolved
Hide resolved
ambry-tools/src/main/java/com.github.ambry/clustermap/HelixVcrPopulateTool.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes requested.
Use customized blobId string as Azure blob name.
Add blobUploadSuccessByteRate and blobUploadSuccessLatency to AzureMetrics.