Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customized blobId string as Azure blob name. #1181

Merged
merged 7 commits into from
Jun 7, 2019

Conversation

zzmao
Copy link
Contributor

@zzmao zzmao commented Jun 5, 2019

Use customized blobId string as Azure blob name.
Add blobUploadSuccessByteRate and blobUploadSuccessLatency to AzureMetrics.

Add blobUploadTotalByteRate and blobUploadTotalLatency to AzureMetrics.
@zzmao zzmao requested a review from lightningrob June 5, 2019 20:46
@@ -41,7 +42,8 @@
public static final String BLOB_DELETION_TIME = "BlobDeletionTime";
public static final String BLOB_DELETE_ERROR_COUNT = "BlobDeleteErrorCount";
public static final String CONFIG_ERROR_COUNT = "ConfigErrorCount";
public static final String BLOB_UPLOAD_RATE = "BlobUploadRate";
public static final String BLOB_UPLOAD_TOTAL_BYTE_RATE = "BlobUploadTotalByteRate";
public static final String BLOB_UPLOAD_TOTAL_LATENCY = "BlobUploadTotalLatency";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latency can be translated to two graph one is meter and the other is timer.

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #1181 into master will increase coverage by 13.94%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1181       +/-   ##
=============================================
+ Coverage     69.67%   83.62%   +13.94%     
+ Complexity     5401       57     -5344     
=============================================
  Files           430        6      -424     
  Lines         33047      348    -32699     
  Branches       4176       38     -4138     
=============================================
- Hits          23026      291    -22735     
+ Misses         8891       45     -8846     
+ Partials       1130       12     -1118
Impacted Files Coverage Δ Complexity Δ
...ava/com.github.ambry/config/PerformanceConfig.java
...main/java/com.github.ambry.cloud/CloudReplica.java
...m.github.ambry.replication/ReplicationMetrics.java
...ava/com.github.ambry/frontend/SecurityService.java
...b.ambry.cloud/CloudBlobCryptoAgentFactoryImpl.java
...ain/java/com.github.ambry/frontend/Operations.java
...n/java/com.github.ambry.clustermap/Datacenter.java
...github.ambry.messageformat/TtlUpdateSubRecord.java
...i/src/main/java/com.github.ambry/network/Port.java
...n/java/com.github.ambry.network/CompositeSend.java
... and 411 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fb467...bd8f82d. Read the comment docs.

@zzmao zzmao changed the title Enhance Azure metrics. Use reverse blobId string as Azure blob name. Jun 5, 2019
@zzmao zzmao requested a review from jsjtzyy June 5, 2019 21:30
@zzmao zzmao changed the title Use reverse blobId string as Azure blob name. Use customized blobId string as Azure blob name. Jun 5, 2019
Copy link
Contributor

@lightningrob lightningrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but see question about histogram metric.

Copy link
Contributor

@lightningrob lightningrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes requested.

@lightningrob lightningrob merged commit 9601dfe into linkedin:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants