Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NettyPerfClient to connect multiple frontends #1217

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

jsjtzyy
Copy link
Contributor

@jsjtzyy jsjtzyy commented Jul 16, 2019

  1. log response based on response code range rather than single response
    code value.
  2. allow perfClient to connect multiple frontends.

1. log response based on response code range rather than single response
code value.
2. allow perfClient to connect multiple frontends.
@jsjtzyy jsjtzyy self-assigned this Jul 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #1217 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1217      +/-   ##
============================================
- Coverage     69.67%   69.66%   -0.02%     
- Complexity     5476     5478       +2     
============================================
  Files           431      431              
  Lines         33554    33573      +19     
  Branches       4258     4262       +4     
============================================
+ Hits          23380    23387       +7     
- Misses         9000     9017      +17     
+ Partials       1174     1169       -5
Impacted Files Coverage Δ Complexity Δ
....github.ambry/tools/perf/rest/NettyPerfClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../main/java/com.github.ambry.router/EncryptJob.java 92.1% <0%> (-5.27%) 4% <0%> (-1%)
...b.ambry.network/BlockingChannelConnectionPool.java 70.42% <0%> (-1.88%) 8% <0%> (ø)
...va/com.github.ambry.replication/ReplicaThread.java 74.62% <0%> (-0.19%) 66% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.13% <0%> (ø) 103% <0%> (-1%) ⬇️
...java/com.github.ambry.network/SSLTransmission.java 69.74% <0%> (+0.31%) 69% <0%> (+1%) ⬆️
...ain/java/com.github.ambry.router/PutOperation.java 90.6% <0%> (+0.35%) 110% <0%> (+2%) ⬆️
....github.ambry.clustermap/StaticClusterManager.java 74.04% <0%> (+1.7%) 83% <0%> (+1%) ⬆️
...github.ambry.rest/AsyncRequestResponseHandler.java 90.87% <0%> (+2.28%) 23% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b311b...2084972. Read the comment docs.

@@ -136,11 +140,12 @@
* Parses the arguments provided and extracts them into variables that can be retrieved.
* @param args the command line argument list.
*/
protected ClientArgs(String args[]) {
ClientArgs(String[] args) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Use 'protected' to be more strict?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore this. Looks good.

Copy link
Contributor

@zzmao zzmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zzmao zzmao merged commit 24f4da8 into linkedin:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants