-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow NettyPerfClient to connect multiple frontends #1217
Conversation
1. log response based on response code range rather than single response code value. 2. allow perfClient to connect multiple frontends.
Codecov Report
@@ Coverage Diff @@
## master #1217 +/- ##
============================================
- Coverage 69.67% 69.66% -0.02%
- Complexity 5476 5478 +2
============================================
Files 431 431
Lines 33554 33573 +19
Branches 4258 4262 +4
============================================
+ Hits 23380 23387 +7
- Misses 9000 9017 +17
+ Partials 1174 1169 -5
Continue to review full report at Codecov.
|
ambry-tools/src/main/java/com.github.ambry/tools/perf/rest/NettyPerfClient.java
Show resolved
Hide resolved
ambry-tools/src/main/java/com.github.ambry/tools/perf/rest/NettyPerfClient.java
Show resolved
Hide resolved
@@ -136,11 +140,12 @@ | |||
* Parses the arguments provided and extracts them into variables that can be retrieved. | |||
* @param args the command line argument list. | |||
*/ | |||
protected ClientArgs(String args[]) { | |||
ClientArgs(String[] args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Use 'protected' to be more strict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore this. Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
code value.