Add cache of recently seen blobs in CloudBlobStore #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary Azure requests.
Codecov Report
@@ Coverage Diff @@
## master #1225 +/- ##
============================================
+ Coverage 69.51% 69.53% +0.02%
- Complexity 5552 5560 +8
============================================
Files 432 432
Lines 33943 33978 +35
Branches 4342 4349 +7
============================================
+ Hits 23596 23628 +32
- Misses 9146 9149 +3
Partials 1201 1201
Continue to review full report at Codecov.
|
dharju
requested changes
Jul 29, 2019
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobStore.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobStore.java
Outdated
Show resolved
Hide resolved
| missingKeys = store.findMissingKeys(keys); | ||
| assertTrue("Expected no missing keys", missingKeys.isEmpty()); | ||
| // getBlobMetadata should not have been called a second time. | ||
| verify(dest).getBlobMetadata(anyList()); |
There was a problem hiding this comment.
Perhaps a unit test to confirm that the LRU nature of the cache works as expected (set the cache limit artificially low, add PUTs over that number, confirm that redoing the PUTs yields (number of PUTs - limit) unskipped cloud PUTs)?
There was a problem hiding this comment.
Done (method a bit different).
zzmao
reviewed
Aug 6, 2019
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobStore.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce unnecessary Azure round trips when multiple replicas send same data.