Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken builds by specifying Ubuntu trusty dist. #1231

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

@lightningrob lightningrob requested review from cgtz, jsjtzyy and zzmao August 6, 2019 18:18
Copy link
Contributor

@jsjtzyy jsjtzyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. Will rebase existing PRs.

Copy link
Contributor

@cgtz cgtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can merge once travis passes

Copy link
Contributor

@zzmao zzmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@codecov-io
Copy link

Codecov Report

Merging #1231 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1231      +/-   ##
============================================
- Coverage     69.58%   69.54%   -0.05%     
+ Complexity     5553     5552       -1     
============================================
  Files           432      432              
  Lines         33943    33943              
  Branches       4342     4342              
============================================
- Hits          23619    23604      -15     
- Misses         9131     9140       +9     
- Partials       1193     1199       +6
Impacted Files Coverage Δ Complexity Δ
...b.ambry.network/BlockingChannelConnectionPool.java 69.48% <0%> (-2.82%) 7% <0%> (-1%)
...java/com.github.ambry.store/CompactionManager.java 87.33% <0%> (-2.67%) 19% <0%> (ø)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.13% <0%> (-0.62%) 103% <0%> (ø)
...ain/java/com.github.ambry.router/PutOperation.java 90.61% <0%> (-0.54%) 111% <0%> (-1%)
...in/java/com.github.ambry.network/SocketServer.java 83.6% <0%> (-0.41%) 15% <0%> (ø)
.../java/com.github.ambry.router/DeleteOperation.java 94.77% <0%> (+1.49%) 45% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f246f...e541c88. Read the comment docs.

@jsjtzyy jsjtzyy merged commit 2f386ac into linkedin:master Aug 6, 2019
@lightningrob lightningrob deleted the travis-trusty branch January 15, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants