Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement decryption for cloud blobstore download blob #1240

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

ankagrawal
Copy link
Collaborator

for cases where the blob was encrypted by cloud blobstore before uploading

Copy link
Contributor

@lightningrob lightningrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, few minor things.

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #1240 into master will decrease coverage by 16.62%.
The diff coverage is 90.47%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1240       +/-   ##
=============================================
- Coverage     88.92%   72.29%   -16.63%     
- Complexity       60     6129     +6069     
=============================================
  Files             6      440      +434     
  Lines           352    35251    +34899     
  Branches         37     4481     +4444     
=============================================
+ Hits            313    25484    +25171     
- Misses           29     8603     +8574     
- Partials         10     1164     +1154
Impacted Files Coverage Δ Complexity Δ
...java/com.github.ambry.cloud/CloudBlobMetadata.java 95.71% <100%> (ø) 33 <4> (?)
...va/com.github.ambry.cloud/CloudMessageReadSet.java 50% <50%> (ø) 3 <0> (?)
...in/java/com.github.ambry.cloud/CloudBlobStore.java 82.77% <91.66%> (ø) 66 <2> (?)
...om/github/ambry/account/AccountServiceMetrics.java 100% <0%> (ø) 1% <0%> (ø) ⬇️
...ava/com.github.ambry/config/PerformanceConfig.java 100% <0%> (ø) 4% <0%> (?)
...main/java/com.github.ambry.cloud/CloudReplica.java 73.91% <0%> (ø) 8% <0%> (?)
...m.github.ambry.replication/ReplicationMetrics.java 94.92% <0%> (ø) 43% <0%> (?)
...ava/com.github.ambry/frontend/SecurityService.java 100% <0%> (ø) 4% <0%> (?)
...b.ambry.cloud/CloudBlobCryptoAgentFactoryImpl.java 81.81% <0%> (ø) 2% <0%> (?)
...ain/java/com.github.ambry/frontend/Operations.java 0% <0%> (ø) 0% <0%> (?)
... and 429 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88550c5...709d946. Read the comment docs.

Copy link
Contributor

@lightningrob lightningrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after addressing one comment.

…e the blob was encrypted by cloud blobstore before uploading
@lightningrob lightningrob merged commit 1ae56b7 into linkedin:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants