Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable signing of build artifacts #1260

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

cgtz
Copy link
Contributor

@cgtz cgtz commented Sep 10, 2019

By default signing artifacts with the bintray public key is enabled.
However, this seems to add about 30 minutes to the :bintrayPublish task,
which is too long for travis-ci builds.

Signed artifacts are not required unless consumers of the libraries are
interested in verifying the signature.

By default signing artifacts with the bintray public key is enabled.
However, this seems to add about 30 minutes to the :bintrayPublish task,
which is too long for travis-ci builds.

Signed artifacts are not required unless consumers of the libraries are
interested in verifying the signature.
@cgtz cgtz requested a review from lightningrob September 10, 2019 19:09
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3e619d0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1260   +/-   ##
=========================================
  Coverage          ?   72.34%           
  Complexity        ?     6131           
=========================================
  Files             ?      440           
  Lines             ?    35225           
  Branches          ?     4478           
=========================================
  Hits              ?    25484           
  Misses            ?     8580           
  Partials          ?     1161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e619d0...22416a9. Read the comment docs.

@lightningrob lightningrob merged commit 3373f29 into linkedin:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants