Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cli tool to perform some account metadata related operations #1268

Merged
merged 5 commits into from
Oct 1, 2019

Conversation

justinlin-linkedin
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #1268 into master will decrease coverage by 0.53%.
The diff coverage is 6.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1268      +/-   ##
============================================
- Coverage     72.54%   72.01%   -0.54%     
- Complexity     6218     6219       +1     
============================================
  Files           448      449       +1     
  Lines         35446    35709     +263     
  Branches       4508     4536      +28     
============================================
+ Hits          25716    25717       +1     
- Misses         8552     8808     +256     
- Partials       1178     1184       +6
Impacted Files Coverage Δ Complexity Δ
...com/github/ambry/account/AccountMetadataStore.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...ain/java/com.github.ambry/account/AccountTool.java 0% <0%> (ø) 0 <0> (?)
....github.ambry/config/HelixPropertyStoreConfig.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...ain/java/com/github/ambry/account/RouterStore.java 74.03% <41.37%> (-6.24%) 13 <3> (+3)
.../com/github/ambry/account/HelixAccountService.java 87.73% <66.66%> (-0.36%) 44 <6> (+1)
...b.ambry.network/BlockingChannelConnectionPool.java 73.68% <0%> (-2.11%) 11% <0%> (-1%)
...va/com.github.ambry.replication/ReplicaThread.java 86.38% <0%> (-1.71%) 90% <0%> (-2%)
...m.github.ambry.replication/ReplicationMetrics.java 94.92% <0%> (-1.21%) 43% <0%> (-1%)
...github.ambry.rest/AsyncRequestResponseHandler.java 87.29% <0%> (-1.01%) 23% <0%> (ø)
...ain/java/com.github.ambry.router/PutOperation.java 91.72% <0%> (-0.51%) 114% <0%> (-1%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3620573...241b82a. Read the comment docs.


/**
* <p>
* This is a command-line tool can be used to perform a number of {@link Account} related operations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you look into combining this tool and AccountUpdateTool? If its possible, then we could potentially get rid of AccountUpdateTool and use AccountTool for everything.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan to push the new account metadata management to prod and then just remove the AccoutUpdateTool.

Copy link
Contributor

@jsjtzyy jsjtzyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after comments are addressed.

@cgtz cgtz merged commit 87638c7 into linkedin:master Oct 1, 2019
@justinlin-linkedin justinlin-linkedin deleted the rollback branch October 1, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants