-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cli tool to perform some account metadata related operations #1268
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1268 +/- ##
============================================
- Coverage 72.54% 72.01% -0.54%
- Complexity 6218 6219 +1
============================================
Files 448 449 +1
Lines 35446 35709 +263
Branches 4508 4536 +28
============================================
+ Hits 25716 25717 +1
- Misses 8552 8808 +256
- Partials 1178 1184 +6
Continue to review full report at Codecov.
|
ambry-tools/src/main/java/com.github.ambry/account/AccountTool.java
Outdated
Show resolved
Hide resolved
|
||
/** | ||
* <p> | ||
* This is a command-line tool can be used to perform a number of {@link Account} related operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you look into combining this tool and AccountUpdateTool
? If its possible, then we could potentially get rid of AccountUpdateTool
and use AccountTool
for everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan to push the new account metadata management to prod and then just remove the AccoutUpdateTool.
ambry-tools/src/main/java/com.github.ambry/account/AccountTool.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after comments are addressed.
No description provided.