Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tests to run when Conscrypt not available #1271

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

cgtz
Copy link
Contributor

@cgtz cgtz commented Oct 1, 2019

  • Check Conscrypt availability before running tests with it to allow
    tests to run on machines with glibc < 2.14.
  • Catch Throwable when checking Conscrypt availability

@cgtz cgtz requested a review from zzmao October 1, 2019 06:18
- Check Conscrypt availability before running tests with it to allow
  tests to run on machines with glibc < 2.14.
- catch Throwable when checking Conscrypt availability
@cgtz cgtz force-pushed the conscrypt-log-error-2 branch from 7d0a070 to 02f6f13 Compare October 1, 2019 06:45
@cgtz cgtz changed the title Catch Throwable when checking Conscrypt availability Allow tests to run when Conscrypt not available Oct 1, 2019
@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #1271 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1271      +/-   ##
============================================
- Coverage     72.08%   72.03%   -0.06%     
+ Complexity     6233     6228       -5     
============================================
  Files           449      449              
  Lines         35737    35737              
  Branches       4540     4540              
============================================
- Hits          25761    25743      -18     
- Misses         8795     8811      +16     
- Partials       1181     1183       +2
Impacted Files Coverage Δ Complexity Δ
...n/java/com.github.ambry.commons/JdkSslFactory.java 72.85% <0%> (ø) 7 <0> (ø) ⬇️
...m.github.ambry.replication/ReplicationMetrics.java 94.92% <0%> (-1.21%) 43% <0%> (-1%)
...c/main/java/com.github.ambry.network/Selector.java 78.21% <0%> (-1.05%) 77% <0%> (-1%)
...github.ambry.rest/AsyncRequestResponseHandler.java 87.29% <0%> (-1.01%) 23% <0%> (ø)
...va/com.github.ambry.replication/ReplicaThread.java 87.33% <0%> (-0.76%) 91% <0%> (-1%)
...java/com.github.ambry.network/SSLTransmission.java 70.89% <0%> (-0.62%) 74% <0%> (-1%)
...ava/com.github.ambry.router/NonBlockingRouter.java 77.26% <0%> (-0.52%) 51% <0%> (-1%)
...ain/java/com.github.ambry.router/PutOperation.java 91.21% <0%> (-0.51%) 113% <0%> (-1%)
...src/main/java/com.github.ambry.commons/BlobId.java 93.52% <0%> (-0.36%) 71% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.04% <0%> (+0.62%) 103% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc68a88...02f6f13. Read the comment docs.

@zzmao zzmao merged commit b03c009 into linkedin:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants