Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Shutdown request handler before network server in ambry server (#1206)" #1273

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

cgtz
Copy link
Contributor

@cgtz cgtz commented Oct 4, 2019

This reverts commit 063ca5e.
We have some suspicions that the frontend may not be able to deal with
this nicely if it is in the middle of writing to a socket.

linkedin#1206)"

This reverts commit 063ca5e.
We have some suspicions that the frontend may not be able to deal with
this nicely if it is in the middle of writing to a socket.
@zzmao
Copy link
Contributor

zzmao commented Oct 4, 2019

Will merge after travis test.

@codecov-io
Copy link

Codecov Report

Merging #1273 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
- Coverage     72.07%   72.04%   -0.04%     
+ Complexity     6235     6233       -2     
============================================
  Files           449      449              
  Lines         35737    35737              
  Branches       4540     4540              
============================================
- Hits          25759    25745      -14     
- Misses         8800     8816      +16     
+ Partials       1178     1176       -2
Impacted Files Coverage Δ Complexity Δ
...main/java/com.github.ambry.server/AmbryServer.java 76.92% <50%> (ø) 6 <0> (ø) ⬇️
...a/com.github.ambry.network/SSLBlockingChannel.java 77.04% <0%> (-4.92%) 4% <0%> (ø)
.../com.github.ambry.network/BlockingChannelInfo.java 82.25% <0%> (-3.23%) 16% <0%> (ø)
...va/com.github.ambry.replication/ReplicaThread.java 86.38% <0%> (-0.95%) 90% <0%> (-1%)
...java/com.github.ambry.network/SSLTransmission.java 70.89% <0%> (-0.93%) 74% <0%> (ø)
...ls/src/main/java/com.github.ambry.utils/Utils.java 74.71% <0%> (-0.38%) 104% <0%> (-1%)
...ain/java/com.github.ambry.router/PutOperation.java 91.72% <0%> (-0.34%) 114% <0%> (ø)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.04% <0%> (+0.2%) 104% <0%> (ø) ⬇️
...java/com.github.ambry.store/CompactionManager.java 92.26% <0%> (+1.78%) 25% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d9e87...d3788f0. Read the comment docs.

@zzmao zzmao merged commit 0c10f66 into linkedin:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants