Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put (uploadBlob) in AzureCloudDestination should autocreate container if not exists #1277

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

ankagrawal
Copy link
Collaborator

No description provided.

@ankagrawal ankagrawal requested review from zzmao and cgtz October 9, 2019 17:35
@codecov-io
Copy link

Codecov Report

Merging #1277 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1277     +/-   ##
===========================================
+ Coverage     72.09%   72.19%   +0.1%     
- Complexity     6232     6239      +7     
===========================================
  Files           449      449             
  Lines         35744    35744             
  Branches       4540     4540             
===========================================
+ Hits          25769    25805     +36     
+ Misses         8796     8760     -36     
  Partials       1179     1179
Impacted Files Coverage Δ Complexity Δ
...ithub.ambry.cloud/azure/AzureCloudDestination.java 80.84% <100%> (+0.38%) 43 <2> (+1) ⬆️
...in/java/com.github.ambry.clustermap/Partition.java 78.16% <0%> (-3.45%) 26% <0%> (-1%)
...github.ambry.rest/AsyncRequestResponseHandler.java 88.29% <0%> (-2.35%) 23% <0%> (ø)
...b.ambry.network/BlockingChannelConnectionPool.java 73.68% <0%> (-2.11%) 11% <0%> (-1%)
.../main/java/com.github.ambry.store/ScanResults.java 81.25% <0%> (-1.57%) 16% <0%> (-1%)
.../java/com.github.ambry.router/DeleteOperation.java 93.28% <0%> (-1.5%) 44% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 70.83% <0%> (-0.84%) 103% <0%> (-2%)
...rc/main/java/com.github.ambry.store/BlobStore.java 89.53% <0%> (-0.7%) 94% <0%> (-3%)
...java/com.github.ambry.store/CompactionManager.java 91.66% <0%> (-0.6%) 25% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a154380...c6b5289. Read the comment docs.

@ankagrawal ankagrawal requested a review from jsjtzyy October 9, 2019 19:14
Copy link
Contributor

@jsjtzyy jsjtzyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

@@ -234,7 +234,7 @@ private boolean uploadIfNotExists(BlobId blobId, long inputLength, CloudBlobMeta
azureMetrics.blobUploadRequestCount.inc();
Timer.Context storageTimer = azureMetrics.blobUploadTime.time();
try {
CloudBlockBlob azureBlob = getAzureBlobReference(blobId);
CloudBlockBlob azureBlob = getAzureBlobReference(blobId, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to add piece of comment for this method when container doesn't exist.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are comments in lines 526 and 529, when we actually create the container. Let me know if you think we need more logging.

Copy link
Contributor

@lightningrob lightningrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wish I had caught the issue in the previous review.

@lightningrob lightningrob merged commit df1bc25 into linkedin:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants