-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put (uploadBlob) in AzureCloudDestination should autocreate container if not exists #1277
Put (uploadBlob) in AzureCloudDestination should autocreate container if not exists #1277
Conversation
… if not already exists
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
===========================================
+ Coverage 72.09% 72.19% +0.1%
- Complexity 6232 6239 +7
===========================================
Files 449 449
Lines 35744 35744
Branches 4540 4540
===========================================
+ Hits 25769 25805 +36
+ Misses 8796 8760 -36
Partials 1179 1179
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor comment.
@@ -234,7 +234,7 @@ private boolean uploadIfNotExists(BlobId blobId, long inputLength, CloudBlobMeta | |||
azureMetrics.blobUploadRequestCount.inc(); | |||
Timer.Context storageTimer = azureMetrics.blobUploadTime.time(); | |||
try { | |||
CloudBlockBlob azureBlob = getAzureBlobReference(blobId); | |||
CloudBlockBlob azureBlob = getAzureBlobReference(blobId, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to add piece of comment for this method when container doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are comments in lines 526 and 529, when we actually create the container. Let me know if you think we need more logging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Wish I had caught the issue in the previous review.
No description provided.