Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PutRequest by removing ReceivedPutRequest #1317

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

justinlin-linkedin
Copy link
Collaborator

We don't really need it ReceivedPutRequest, just like we don't have ReceivedGetResponse.

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #1317 into master will increase coverage by 0.04%.
The diff coverage is 92.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1317      +/-   ##
============================================
+ Coverage     72.02%   72.06%   +0.04%     
- Complexity     6421     6431      +10     
============================================
  Files           468      468              
  Lines         36949    36932      -17     
  Branches       4650     4647       -3     
============================================
+ Hits          26611    26614       +3     
+ Misses         9103     9079      -24     
- Partials       1235     1239       +4
Impacted Files Coverage Δ Complexity Δ
.../java/com.github.ambry.protocol/AmbryRequests.java 83.65% <100%> (ø) 67 <0> (ø) ⬇️
...ain/java/com.github.ambry.protocol/PutRequest.java 79.85% <92.3%> (+7.66%) 27 <8> (+9) ⬆️
...ub.ambry.network/SocketRequestResponseChannel.java 86.36% <0%> (-1.52%) 10% <0%> (ø)
...c/main/java/com.github.ambry.network/Selector.java 78.21% <0%> (-0.79%) 77% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 70.83% <0%> (-0.42%) 103% <0%> (ø)
...src/main/java/com.github.ambry.commons/BlobId.java 93.05% <0%> (-0.35%) 73% <0%> (-1%)
...rc/main/java/com.github.ambry.store/BlobStore.java 90.06% <0%> (-0.24%) 97% <0%> (-1%)
...va/com.github.ambry.rest/NettyResponseChannel.java 91.82% <0%> (-0.22%) 117% <0%> (-1%)
...ls/src/main/java/com.github.ambry.utils/Utils.java 76.89% <0%> (+0.33%) 114% <0%> (+1%) ⬆️
...va/com.github.ambry.replication/ReplicaThread.java 86.76% <0%> (+0.37%) 91% <0%> (+1%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d821251...90f8ddc. Read the comment docs.

Copy link
Contributor

@lightningrob lightningrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zzmao zzmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzmao zzmao merged commit 4488e00 into linkedin:master Nov 21, 2019
@justinlin-linkedin justinlin-linkedin deleted the putrequests branch November 21, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants