Adding an option to enable/disable TCP_NODELAY socket option #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
============================================
- Coverage 72.13% 72.11% -0.03%
- Complexity 6455 6456 +1
============================================
Files 469 469
Lines 37071 37081 +10
Branches 4660 4660
============================================
- Hits 26743 26740 -3
- Misses 9087 9103 +16
+ Partials 1241 1238 -3
Continue to review full report at Codecov.
|
dniq
force-pushed
the
tcp_nodelay_option
branch
from
85616bc
to
085213f
Compare
jsjtzyy
reviewed
Nov 22, 2019
ambry-api/src/main/java/com.github.ambry/config/ConnectionPoolConfig.java
Outdated
Show resolved
Hide resolved
ambry-network/src/main/java/com.github.ambry.network/BlockingChannel.java
Outdated
Show resolved
Hide resolved
ambry-network/src/main/java/com.github.ambry.network/BlockingChannel.java
Outdated
Show resolved
Hide resolved
ambry-network/src/main/java/com.github.ambry.network/BlockingChannelInfo.java
Outdated
Show resolved
Hide resolved
dniq
force-pushed
the
tcp_nodelay_option
branch
from
085213f
to
3b9a541
Compare
This change adds a configuration property to enable or disable TCP_NODELAY socket option in BlockingChannel (used for replication only ATM)
dniq
force-pushed
the
tcp_nodelay_option
branch
from
3b9a541
to
1c00cb7
Compare
jsjtzyy
approved these changes
Nov 26, 2019
| this(host, port, readBufferSize, writeBufferSize, readTimeoutMs, connectTimeoutMs, true); | ||
| } | ||
|
|
||
| public BlockingChannel(String host, int port, ConnectionPoolConfig config) { |
There was a problem hiding this comment.
optional: can be package-private (public can be removed)
cgtz
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a configuration property to enable or disable TCP_NODELAY socket option in BlockingChannel (used for replication only ATM) and adds an additional (optional) parameter for the same. If the parameter is not provided - a default 'true' (enabled) is assumed. This means that the tests (which have not been updated) will have TCP_NODELAY socket option set to 'true'.