Use async cosmos library and upgrade to 2.6.3 #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankagrawal
commented
Nov 25, 2019
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/CosmosDataAccessor.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
=========================================
Coverage ? 72.16%
Complexity ? 6498
=========================================
Files ? 472
Lines ? 37265
Branches ? 4707
=========================================
Hits ? 26893
Misses ? 9120
Partials ? 1252
Continue to review full report at Codecov.
|
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/test/java/com.github.ambry.cloud/azure/AzureCloudDestinationTest.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
lightningrob
reviewed
Dec 5, 2019
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Outdated
Show resolved
Hide resolved
lightningrob
approved these changes
Dec 5, 2019
cgtz
approved these changes
Dec 5, 2019
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/CosmosDataAccessor.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/CosmosDataAccessor.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/CosmosDataAccessor.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/CosmosDataAccessor.java
Outdated
Show resolved
Hide resolved
ankagrawal
force-pushed
the
upgradecosmos
branch
from
3108e13 to
f72d240
Compare
lightningrob
reviewed
Dec 6, 2019
| * @param documentList {@link List <Document>} of documents to return from mocked call. | ||
| * @param mockResponse {@link Observable} mocked response. | ||
| */ | ||
| static void mockObservableForQuery(List<Document> documentList, Observable<FeedResponse<Document>> mockResponse) { |
There was a problem hiding this comment.
Minor: this method can create and return the mockResponse like the others. Okay to change in follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes replaces the cosmos documentdb library with async cosmosdb library.