Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CryptoService to work with CompositeByteBuf #1323

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

justinlin-linkedin
Copy link
Collaborator

PutOperation would read multiple ByteBuf as a Composite from NettyServer layer. If the blob should be encrypted, then the crypto service has to work with CompositeByteBuf. This PR adds such support.

Copy link
Contributor

@cgtz cgtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #1323 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1323      +/-   ##
============================================
- Coverage     72.16%   72.08%   -0.09%     
+ Complexity     6536     6533       -3     
============================================
  Files           478      478              
  Lines         37330    37374      +44     
  Branches       4714     4722       +8     
============================================
+ Hits          26941    26942       +1     
- Misses         9142     9174      +32     
- Partials       1247     1258      +11
Impacted Files Coverage Δ Complexity Δ
...ls/src/main/java/com.github.ambry.utils/Utils.java 77.24% <100%> (+0.34%) 116 <2> (+2) ⬆️
...java/com.github.ambry.router/GCMCryptoService.java 89.31% <100%> (+1.48%) 18 <0> (+4) ⬆️
...in/java/com.github.ambry/router/CryptoService.java 100% <100%> (+100%) 4 <4> (+4) ⬆️
...b.ambry.clustermap/StaticClusterAgentsFactory.java 33.33% <0%> (-6.67%) 4% <0%> (ø)
...ry.replication/CloudToStoreReplicationManager.java 53.42% <0%> (-3.62%) 10% <0%> (ø)
...b.ambry.network/BlockingChannelConnectionPool.java 73.68% <0%> (-2.11%) 11% <0%> (-1%)
.../main/java/com.github.ambry.store/ScanResults.java 81.25% <0%> (-1.57%) 16% <0%> (-1%)
.../java/com.github.ambry.router/DeleteOperation.java 93.43% <0%> (-1.46%) 44% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.25% <0%> (-1.25%) 103% <0%> (-2%)
...m.github.ambry.replication/ReplicationMetrics.java 94.97% <0%> (-1.2%) 43% <0%> (-1%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8014eb...1ebcde7. Read the comment docs.

@cgtz cgtz merged commit b17165d into linkedin:master Dec 18, 2019
@justinlin-linkedin justinlin-linkedin deleted the cryptoservice branch December 18, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants