-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CryptoService to work with CompositeByteBuf #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ambry-router/src/main/java/com.github.ambry.router/GCMCryptoService.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com.github.ambry/router/CryptoService.java
Outdated
Show resolved
Hide resolved
8a37916
to
d79a685
Compare
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
============================================
- Coverage 72.16% 72.08% -0.09%
+ Complexity 6536 6533 -3
============================================
Files 478 478
Lines 37330 37374 +44
Branches 4714 4722 +8
============================================
+ Hits 26941 26942 +1
- Misses 9142 9174 +32
- Partials 1247 1258 +11
Continue to review full report at Codecov.
|
PutOperation would read multiple ByteBuf as a Composite from NettyServer layer. If the blob should be encrypted, then the crypto service has to work with CompositeByteBuf. This PR adds such support.