Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Azure storage v12 into AzureCloudDestination #1324

Merged
merged 7 commits into from
Dec 7, 2019

Conversation

lightningrob
Copy link
Contributor

Also remove unused CloudDestination.doesBlobExist()

@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #1324 into master will decrease coverage by 0.02%.
The diff coverage is 73.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1324      +/-   ##
============================================
- Coverage     72.15%   72.12%   -0.03%     
+ Complexity     6498     6496       -2     
============================================
  Files           472      472              
  Lines         37265    37204      -61     
  Branches       4707     4703       -4     
============================================
- Hits          26888    26835      -53     
+ Misses         9124     9118       -6     
+ Partials       1253     1251       -2
Impacted Files Coverage Δ Complexity Δ
...ithub.ambry.cloud/azure/AzureBlobDataAccessor.java 80.29% <72.91%> (+1.2%) 20 <8> (+8) ⬆️
...ithub.ambry.cloud/azure/AzureCloudDestination.java 70% <76.47%> (-3.89%) 29 <1> (-10)
...java/com.github.ambry.store/CompactionManager.java 89.88% <0%> (-1.79%) 25% <0%> (ø)
.../main/java/com.github.ambry.store/ScanResults.java 81.25% <0%> (-1.57%) 16% <0%> (-1%)
...java/com.github.ambry.network/SSLTransmission.java 70.46% <0%> (-0.93%) 76% <0%> (ø)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.25% <0%> (-0.63%) 104% <0%> (-1%)
...ls/src/main/java/com.github.ambry.utils/Utils.java 76.56% <0%> (-0.34%) 113% <0%> (-1%)
...ain/java/com.github.ambry.router/PutOperation.java 91.8% <0%> (ø) 114% <0%> (ø) ⬇️
...rc/main/java/com.github.ambry.store/BlobStore.java 89.77% <0%> (+0.22%) 100% <0%> (+1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1411228...f433073. Read the comment docs.

Copy link
Collaborator

@ankagrawal ankagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Do remember to run AzureIntegrationTest before checking in.

Copy link
Contributor

@cgtz cgtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing these comments.

RequestRetryOptions requestRetryOptions = new RequestRetryOptions();
storageClient = new BlobServiceClientBuilder().connectionString(azureCloudConfig.azureStorageConnectionString)
.httpClient(client)
.retryOptions(requestRetryOptions)
.configuration(storageConfiguration)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storageConfiguration appears to now be empty. does it still have to be passed into the builder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally was setting something in it and removed it. Figured I'd keep it as a placeholder in case we need it later.

@@ -123,6 +123,7 @@ subprojects {
// TODO audit and fix our javadocs so that we don't need this setting
// This is mainly for cases where param/throws tags don't have descriptions
// Previously, javadocs weren't being compiled, but now shipkit automatically enables this build step
options.addStringOption('Xdoclint:none', '-quiet') // Suppress lint warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding this option!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a way to really customize it and error out on specific things, it's basically all or nothing so I chose nothing to cut down the noise.

@cgtz cgtz merged commit 31adf46 into linkedin:master Dec 7, 2019
@lightningrob lightningrob deleted the azure-storage-v12 branch January 15, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants