Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undelete blob store #1338

Closed
wants to merge 19 commits into from
Closed

Undelete blob store #1338

wants to merge 19 commits into from

Conversation

dharju
Copy link
Contributor

@dharju dharju commented Dec 16, 2019

BlobStore changes for undelete to support replication, writing undelete to log

@codecov-io
Copy link

Codecov Report

Merging #1338 into master will decrease coverage by 0.27%.
The diff coverage is 40.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1338      +/-   ##
============================================
- Coverage     72.16%   71.89%   -0.28%     
+ Complexity     6536     6534       -2     
============================================
  Files           478      479       +1     
  Lines         37330    37452     +122     
  Branches       4714     4744      +30     
============================================
- Hits          26941    26927      -14     
- Misses         9142     9255     +113     
- Partials       1247     1270      +23
Impacted Files Coverage Δ Complexity Δ
...ava/com.github.ambry.store/BlobStoreCompactor.java 92.12% <ø> (ø) 156 <0> (ø) ⬇️
...essageformat/UndeleteMessageFormatInputStream.java 0% <0%> (ø) 0 <0> (?)
...rc/main/java/com.github.ambry.store/BlobStore.java 78.8% <10.6%> (-10.98%) 99 <0> (-1)
...va/com.github.ambry.replication/ReplicaThread.java 87.33% <100%> (-0.76%) 91 <0> (-2)
.../java/com.github.ambry.protocol/AmbryRequests.java 83.65% <100%> (ø) 67 <0> (ø) ⬇️
...n/java/com.github.ambry/store/StoreErrorCodes.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...in/java/com.github.ambry.cloud/CloudBlobStore.java 82.15% <50%> (-0.35%) 69 <0> (ø)
....messageformat/DeleteMessageFormatInputStream.java 75% <58.33%> (-25%) 2 <2> (ø)
...n/java/com.github.ambry.store/PersistentIndex.java 91.05% <72.88%> (-1.56%) 220 <15> (+12)
...a/com.github.ambry.network/SSLBlockingChannel.java 75.67% <0%> (-5.41%) 4% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8014eb...6e56fae. Read the comment docs.

@justinlin-linkedin
Copy link
Collaborator

closed #1373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants