Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional release bug #1367

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Conversation

justinlin-linkedin
Copy link
Collaborator

There is another place where forEach method is used to release the ResponseInfo. This PR fixes that.

* Release all the {@link ResponseInfo} in the map. Use {@link ConcurrentHashMap#remove(Object)} method to avoid
* conflict with the release call in the chunk async callback.
*/
private void releaseResourse() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor spelling: releaseResource.

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #1367 into master will decrease coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1367      +/-   ##
============================================
- Coverage     71.97%   71.96%   -0.02%     
  Complexity     6675     6675              
============================================
  Files           485      485              
  Lines         38031    38032       +1     
  Branches       4820     4820              
============================================
- Hits          27372    27368       -4     
- Misses         9356     9364       +8     
+ Partials       1303     1300       -3
Impacted Files Coverage Δ Complexity Δ
...java/com.github.ambry.router/GetBlobOperation.java 91.7% <87.5%> (+0.01%) 40 <0> (ø) ⬇️
...a/com.github.ambry.network/SSLBlockingChannel.java 75.67% <0%> (-5.41%) 4% <0%> (ø)
...c/main/java/com.github.ambry.network/Selector.java 78.21% <0%> (-1.84%) 77% <0%> (-2%)
.../java/com.github.ambry.router/DeleteOperation.java 93.43% <0%> (-1.46%) 44% <0%> (-1%)
...va/com.github.ambry.replication/ReplicaThread.java 86.61% <0%> (-0.93%) 93% <0%> (-1%)
...java/com.github.ambry.network/SSLTransmission.java 70.46% <0%> (-0.93%) 76% <0%> (ø)
...in/java/com.github.ambry.network/SocketServer.java 85.3% <0%> (-0.41%) 15% <0%> (ø)
...src/main/java/com.github.ambry.commons/BlobId.java 93.05% <0%> (-0.35%) 73% <0%> (-1%)
...ls/src/main/java/com.github.ambry.utils/Utils.java 77.24% <0%> (-0.33%) 116% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 70.83% <0%> (+0.2%) 104% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b552f...8a227a0. Read the comment docs.

@cgtz cgtz merged commit 52bc7c2 into linkedin:master Jan 24, 2020
@justinlin-linkedin justinlin-linkedin deleted the morerefcntfix branch January 24, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants