Default to use netty bytebuf in network layer and remove getAndRelease method #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
============================================
+ Coverage 72.35% 72.51% +0.15%
+ Complexity 6867 6861 -6
============================================
Files 496 496
Lines 38854 38782 -72
Branches 4940 4927 -13
============================================
+ Hits 28113 28122 +9
+ Misses 9383 9308 -75
+ Partials 1358 1352 -6
Continue to review full report at Codecov.
|
cgtz
reviewed
Feb 12, 2020
ambry-api/src/main/java/com.github.ambry/network/NetworkRequest.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com.github.ambry/network/BoundedNettyByteBufReceive.java
Outdated
Show resolved
Hide resolved
justinlin-linkedin
force-pushed
the
getandrelease
branch
from
1029456 to
765be42
Compare
jsjtzyy
reviewed
Feb 13, 2020
ambry-api/src/main/java/com.github.ambry/network/BoundedNettyByteBufReceive.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com.github.ambry/network/BoundedNettyByteBufReceive.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com.github.ambry/network/ResponseInfo.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com.github.ambry/network/ResponseInfo.java
Outdated
Show resolved
Hide resolved
ambry-messageformat/src/main/java/com.github.ambry.messageformat/BlobData.java
Outdated
Show resolved
Hide resolved
ambry-network/src/main/java/com.github.ambry.network/LocalRequestResponseChannel.java
Show resolved
Hide resolved
ambry-network/src/main/java/com.github.ambry.network/SocketRequestResponseChannel.java
Outdated
Show resolved
Hide resolved
| SocketServerRequest req = new SocketServerRequest(id, connectionId, buffer, | ||
| Utils.createDataInputStreamFromBuffer(buffer, networkConfig.networkPutRequestShareMemory)); | ||
| ByteBuf buffer = networkReceive.getReceivedBytes().content(); | ||
| SocketServerRequest req = new SocketServerRequest(id, connectionId, buffer); |
There was a problem hiding this comment.
who is supposed to release the buffer?
There was a problem hiding this comment.
in the RequestHandler, we have a for loop to get the request out and after dealing with the request, we release it.
ambry-network/src/test/java/com.github.ambry.network/SSLSelectorTest.java
Show resolved
Hide resolved
cgtz
approved these changes
Feb 14, 2020
jsjtzyy
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes two changes: