Fix default value for maxCachedBufferCapacity in NettyByteBufLeakHelper #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache is actually enabled by default if the property is not set. Use a default value copied from the netty source.
justinlin-linkedin
approved these changes
Feb 11, 2020
jsjtzyy
approved these changes
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## fix-bytebuf-cacheEnabled #1381 +/- ##
===========================================================
Coverage ? 72.38%
Complexity ? 6871
===========================================================
Files ? 496
Lines ? 38854
Branches ? 4940
===========================================================
Hits ? 28125
Misses ? 9375
Partials ? 1354Continue to review full report at Codecov.
|
cgtz
added a commit
that referenced
this pull request
Feb 11, 2020
…er (#1381) The cache is actually enabled by default if the property is not set. Use a default value copied from the netty source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache is actually enabled by default if the property is not set.
Use a default value copied from the netty source.
This allows the tests to pass in the intellij test runner that does not
run junit with the system properties in build.gradle