[Sample PR|WIP] Spark View Catalog with HMS and Coral #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you make the design doc public and link it from here? |
@wmoustafa Added in the description, but due to the org restriction, I can only share a copied doc (without previous comments) from my personal google account. |
ljfgem
force-pushed
the
coral_spark_view_catalog
branch
from
240a7f7
to
ab3e717
Compare
ljfgem
force-pushed
the
coral_spark_view_catalog
branch
from
ab3e717
to
9d25f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Doc: Spark View Catalog with Coral & HMS
This PR is mostly based on the upstream Spark view catalog PR with some modifications on that PR:
CatalogAndIdentifierrather thanNonSessionCatalogAndIdentifierduring the view substitution, because there might be the use case thatspark_catalog(session catalog) is set to be custom table & view catalog.NonSessionCatalogAndIdentifierdoesn't support such a use case. Commented on the upstream PR.The unit tests worked well.