Replace FunctionFieldReferenceOperator with Calcite DOT operator #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
We can get rid of
FunctionFieldReferenceOperator
entirely and replace it with Calcite's defaultSqlDotOperator
. HistoricallyFunctionFieldReferenceOperator
was introduced because "Calcite DOT operator by default does not work for referencing fields from struct return types of functions." However, that's no longer the case, thus renderingFunctionFieldReferenceOperator
unneeded. If we can get rid ofFunctionFieldReferenceOperator
, we also no longer need to migrate it (as part of Coral IR upgrades).How was this patch tested?
Only regression I'm seeing is a cosmetic one that is actually desirable. Unnecessary parentheses introduced because FunctionFieldReferenceOperator is not a native Calcite operator go away: