Java 17 support #2248
Java 17 support #2248
Conversation
Signed-off-by: Andras Katona <akatona@cloudera.com>
|
This change is not moving away from jdk11 yet, it's just making it possible to compile with java17 too. |
|
|
||
| defaultTestJvmArgs = [] | ||
| // "JEP 403: Strongly Encapsulate JDK Internals" causes some tests to fail when they try | ||
| // to access internals (often via mocking libraries). We use `--add-opens` as a workaround |
There was a problem hiding this comment.
often or always? As I see it is only used in the test task def, so perhaps we could rephrase this.
There was a problem hiding this comment.
I think it's more about the occurrences rather than temporal frequency. OFC those tests always fail without the add-opens.
BTW I copied it from Kafka :D. Most of the cases tests were failing because of easymock and powermock to be specific, but I have no clue why exactly java.time had to be opened, gradle wasn't kind enough to provide me more info about the failing test(s) before I added it.
There was a problem hiding this comment.
In Kafka easymock/powermock was replaced with mockito over time. It's still not done, but that's the way to get rid of these add-opens lateron.
There was a problem hiding this comment.
Ok, makes sense. I agree that we should rather use Mockito, however I think that comes with some test refactoring as well, so let's not do that now.
|
@bgrishinko would you please review this? |
Summary
Expected Behavior
build goes smoothly with java 17
Actual Behavior
build and tests fail with java 17
Steps to Reproduce
./gradlew buildand see the crashesKnown Workarounds
Categorization