-
Notifications
You must be signed in to change notification settings - Fork 855
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
changed logic to fetch spilled bytes information from executors
- Loading branch information
swasti
committed
Dec 7, 2017
1 parent
af29f4b
commit 204d5a7
Showing
7 changed files
with
174 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
test/com/linkedin/drelephant/spark/heuristics/ExecutorStorageSpillHeuristicTest.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /* | ||
| * Copyright 2016 LinkedIn Corp. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package com.linkedin.drelephant.spark.heuristics | ||
|
|
||
| import scala.collection.JavaConverters | ||
| import com.linkedin.drelephant.analysis.{ApplicationType, Severity, SeverityThresholds} | ||
| import com.linkedin.drelephant.configurations.heuristic.HeuristicConfigurationData | ||
| import com.linkedin.drelephant.spark.data.{SparkApplicationData, SparkLogDerivedData, SparkRestDerivedData} | ||
| import com.linkedin.drelephant.spark.fetchers.statusapiv1.{ApplicationInfoImpl, ExecutorSummaryImpl, StageDataImpl} | ||
| import org.apache.spark.scheduler.SparkListenerEnvironmentUpdate | ||
| import org.scalatest.{FunSpec, Matchers} | ||
|
|
||
|
|
||
| class ExecutorStorageSpillHeuristicTest extends FunSpec with Matchers { | ||
| import ExecutorStorageSpillHeuristicTest._ | ||
|
|
||
| describe("ExecutorStorageSpillHeuristic") { | ||
| val heuristicConfigurationData = newFakeHeuristicConfigurationData( | ||
| Map( | ||
| "max_to_median_ratio_severity_thresholds" -> "1.414,2,4,16", | ||
| "ignore_max_bytes_less_than_threshold" -> "4000000", | ||
| "ignore_max_millis_less_than_threshold" -> "4000001" | ||
| ) | ||
| ) | ||
| val executorStorageSpillHeuristic = new ExecutorStorageSpillHeuristic(heuristicConfigurationData) | ||
|
|
||
| val appConfigurationProperties = Map("spark.executor.memory" -> "4g", "spark.executor.cores"->"4") | ||
|
|
||
| val executorSummaries = Seq( | ||
| newFakeExecutorSummary( | ||
| id = "1", | ||
| totalMemoryBytesSpilled = 200000L | ||
| ), | ||
| newFakeExecutorSummary( | ||
| id = "2", | ||
| totalMemoryBytesSpilled = 100000L | ||
| ), | ||
| newFakeExecutorSummary( | ||
| id = "3", | ||
| totalMemoryBytesSpilled = 300000L | ||
| ), | ||
| newFakeExecutorSummary( | ||
| id = "4", | ||
| totalMemoryBytesSpilled = 200000L | ||
| ) | ||
| ) | ||
|
|
||
| describe(".apply") { | ||
| val data1 = newFakeSparkApplicationData(executorSummaries, appConfigurationProperties) | ||
| val heuristicResult = executorStorageSpillHeuristic.apply(data1) | ||
| val heuristicResultDetails = heuristicResult.getHeuristicResultDetails | ||
|
|
||
| it("returns the severity") { | ||
| heuristicResult.getSeverity should be(Severity.SEVERE) | ||
| } | ||
|
|
||
| it("returns the total memory spilled") { | ||
| val details = heuristicResultDetails.get(0) | ||
| details.getName should include("Total memory spilled") | ||
| details.getValue should be("781.25 KB") | ||
| } | ||
|
|
||
| it("returns the max memory spilled") { | ||
| val details = heuristicResultDetails.get(1) | ||
| details.getName should include("Max memory spilled") | ||
| details.getValue should be("292.97 KB") | ||
| } | ||
|
|
||
| it("returns the mean memory spilled") { | ||
| val details = heuristicResultDetails.get(2) | ||
| details.getName should include("Mean memory spilled") | ||
| details.getValue should be("195.31 KB") | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| object ExecutorStorageSpillHeuristicTest { | ||
| import JavaConverters._ | ||
|
|
||
| def newFakeHeuristicConfigurationData(params: Map[String, String] = Map.empty): HeuristicConfigurationData = | ||
| new HeuristicConfigurationData("heuristic", "class", "view", new ApplicationType("type"), params.asJava) | ||
|
|
||
| def newFakeExecutorSummary( | ||
| id: String, | ||
| totalMemoryBytesSpilled: Long | ||
| ): ExecutorSummaryImpl = new ExecutorSummaryImpl( | ||
| id, | ||
| hostPort = "", | ||
| rddBlocks = 0, | ||
| memoryUsed=0, | ||
| diskUsed = 0, | ||
| activeTasks = 0, | ||
| failedTasks = 0, | ||
| completedTasks = 0, | ||
| totalTasks = 0, | ||
| totalDuration=0, | ||
| totalInputBytes=0, | ||
| totalShuffleRead=0, | ||
| totalShuffleWrite= 0, | ||
| maxMemory= 0, | ||
| totalMemoryBytesSpilled, | ||
| executorLogs = Map.empty | ||
| ) | ||
|
|
||
| def newFakeSparkApplicationData( | ||
| executorSummaries: Seq[ExecutorSummaryImpl], | ||
| appConfigurationProperties: Map[String, String] | ||
| ): SparkApplicationData = { | ||
| val appId = "application_1" | ||
|
|
||
| val restDerivedData = SparkRestDerivedData( | ||
| new ApplicationInfoImpl(appId, name = "app", Seq.empty), | ||
| jobDatas = Seq.empty, | ||
| stageDatas = Seq.empty, | ||
| executorSummaries = executorSummaries | ||
| ) | ||
|
|
||
| val logDerivedData = SparkLogDerivedData( | ||
| SparkListenerEnvironmentUpdate(Map("Spark Properties" -> appConfigurationProperties.toSeq)) | ||
| ) | ||
|
|
||
| SparkApplicationData(appId, restDerivedData, Some(logDerivedData)) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters