Mrfetcher ignores failed tasks #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 14, 2017 18:39
…or uptime is allocated resources and task time is used resources
…w executor uptime is allocated resources and task time is used resources" This reverts commit b6cbbe4.
…are counted against the resource usage. Also, fixes the exception stack trace not showing for failed jobs
akshayrai
approved these changes
May 25, 2017
| @@ -235,52 +235,53 @@ public MapReduceApplicationData fetchData(AnalyticJob job) throws IOException { | |||
| jobData.setFinishTime(jobInfo.getFinishTime()); | |||
|
|
|||
| String state = jobInfo.getJobStatus(); | |||
| if (state.equals("SUCCEEDED")) { | |||
|
|
|||
| if( state.equals("SUCCEEDED")) { | |||
| <td>{{yarnappheuristicresultdetail.name}}</td> | ||
| <td>{{yarnappheuristicresultdetail.value}}</td> | ||
| </tr> | ||
| {{#if (not-empty yarnappheuristicresultdetail.details) }} |
There was a problem hiding this comment.
In case of a failed job, the heuristic details (name, value and details) are as follows:
Error, Stacktrace, <actual_stacktrace>
It would be good to check if yarnappheuristicresultdetail.name equals "Error" rather than checking if details is non-empty. In the future if we plan to include details for other heuristics then this can break.
|
@akshayrai Fixed your comments. Take a look and merge if it looks good. |
skakker
pushed a commit
to skakker/dr-elephant
that referenced
this pull request
Dec 14, 2017
* We have been ignoring Failed Tasks in calculation of resource usage. This handles that. * Fixes Exception heuristic which was supposed to give the stacktrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes a couple of things
I still need to test this change with the FS fetcher and potentially add a couple of unittests.