added logic for map-reduce time-skew heuristic #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayrai
reviewed
Jul 28, 2017
| @@ -27,11 +27,18 @@ | |||
| private String _taskId; | |||
| // The successful attempt id | |||
| private String _attemptId; | |||
|
|
|||
| public void setTotalTimeMs(long _totalTimeMs, boolean _isTimeDataPresent) { | |||
There was a problem hiding this comment.
Remove leading underscore from the method parameters.
web/package-lock.json
Outdated
| @@ -0,0 +1,8310 @@ | |||
| { | |||
| import com.linkedin.drelephant.configurations.heuristic.HeuristicConfigurationData; | ||
| import com.linkedin.drelephant.util.Utils; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
Please expand each of the imports unless they are more than 5.
| } | ||
| } | ||
|
|
||
| long wasehi = tasks[5].getTotalRunTimeMs(); |
| * This Heuristic analyses the skewness in the task input data | ||
| */ | ||
| public abstract class GenericSkewHeuristic implements Heuristic<MapReduceApplicationData> { | ||
| private static final Logger logger = Logger.getLogger(GenericSkewHeuristic.class); |
akshayrai
approved these changes
Jul 28, 2017
skakker
added a commit
to skakker/dr-elephant
that referenced
this pull request
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.