fix: Security bug about prototype pollution #805
Merged
+907
−741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeetkakkar
force-pushed
the
fix/proto-pollution
branch
from
1b8adb7 to
67e03cb
Compare
|
kumarrishav
reviewed
Sep 20, 2021
| Object.prototype.MAL_CODE= [ malicious ]; | ||
| const compiled = dust.compile('{username} is an important person.{~n}'); | ||
| const tmpl = dust.loadSource(compiled); | ||
| dust.render(tmpl, { username: 'Jane Doe' }, (err, output) => { |
There was a problem hiding this comment.
how did we test this?
what should be the result of this test without the above fix
There was a problem hiding this comment.
It will execute curl 127.0.0.1 and the test fails
sumeetkakkar
force-pushed
the
fix/proto-pollution
branch
from
67e03cb to
ddb6523
Compare
kumarrishav
approved these changes
Oct 13, 2021
grawk
approved these changes
Oct 13, 2021
| @@ -70,6 +70,9 @@ | |||
| type = type || INFO; | |||
| if (loggingLevels[type] >= loggingLevels[dust.debugLevel]) { | |||
| log('[DUST:' + type + ']', message); | |||
| if (type === ERROR && dust.debugLevel === DEBUG && message instanceof Error && message.stack) { | |||
There was a problem hiding this comment.
Were errors just logging [Object] or something like that before this change?
There was a problem hiding this comment.
This is generated file.
The primary code change I added is in https://github.com/linkedin/dustjs/pull/805/files#diff-544803892ac752aa674ffa81380c022af562eda776860d94eb5c2d3bdb59c99c
This was referenced Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #804