Fix 33cf133 #22
Closed
Fix 33cf133 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pip install .`)" This reverts commit a2ad1bc.
Pull Request Test Coverage Report for Build 40
💛 - Coveralls |
rouge8
reviewed
May 5, 2018
| @@ -68,6 +59,10 @@ def install(interpreter_path: str, args: List[str]) -> None: | |||
| """ | |||
| with clean_pip_env(): | |||
|
|
|||
| # convert '.' to absolute path if it exists | |||
| if '.' in args: | |||
There was a problem hiding this comment.
this will break if someone uses ... Not sure how comprehensive you want to be. Maybe:
# convert '.' to absolute paths if it exists
for i, arg in enumerate(args):
if arg.startswith('.'):
args[i] = Path.cwd().joinpath(arg).absolute().as_posix()
|
@rouge8 unfortunately I'm still hitting the "error: must supply either home or prefix/exec-prefix -- not both" issue here... |
Hmmm, now I'm wondering if #18 actually worked or if I was just hitting cached pip builds... |
|
@rouge8 I'm gonna go ahead and revert our PRs, will you be at PyCon by chance? |
|
absolutely, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use
.in our installation arguments while still avoiding the Homebrew prefix bug fixed by #18