Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing arguments nullability in FunctionMetadata #151

Merged
merged 1 commit into from
May 17, 2023

Conversation

weijiii
Copy link
Contributor

@weijiii weijiii commented May 16, 2023

Summary

  • Should fix the issues in some test failures #149
  • Related concern was raised here
  • Trino engine does not invoke function when non-nullable arguments receive null value; this is determined by FunctionMetadata#functionNullability
  • FunctionMetadata#argumentNullability expects Boolean object
  • Revert changes in TestFileLookUp, since Trino actually throws NullPointerException in this case

@weijiii weijiii changed the title Patch up function metadata for arguments nullability Fix missing arguments nullability in FunctionMetadata May 16, 2023
@weijiii
Copy link
Contributor Author

weijiii commented May 16, 2023

@yiqiangin Can you please check if the other isTrinoTest usage are needed and request changes? Thanks.

@yiqiangin
Copy link
Contributor

@yiqiangin Can you please check if the other isTrinoTest usage are needed and request changes? Thanks.

Other usages of isTrinoTest are still needed as they are not related to null argument.
Also With this code change, all tests in standard-udf-userinterfacelookup and standard-udfs-dali-udfs can pass now.

@yiqiangin yiqiangin merged commit d2d62d2 into linkedin:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants