Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Shadow Jar Source #156

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Upgrade Shadow Jar Source #156

merged 1 commit into from
Oct 17, 2023

Conversation

ianvkoeppe
Copy link
Contributor

@ianvkoeppe ianvkoeppe commented Oct 11, 2023

Summary

Upgrading shadow jar. This plugin source is outdated and preventing use within newer projects.

Testing Done

  1. Project Builds Successfully
  2. Unit Tests All Pass

Copy link

@770120041 770120041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test section in this PR?

Copy link

@770120041 770120041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test section to the PR, otherwise lgtm

Copy link
Contributor

@yiqiangin yiqiangin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianvkoeppe Could you help add how this PR is tested in the description? Thanks.

yiqiangin
yiqiangin previously approved these changes Oct 16, 2023
@rzhang10 rzhang10 merged commit 0acb185 into linkedin:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants