Add tests for handler

linkedin · Feb 14, 2025 · 9ad95eb · 9ad95eb
1 parent 3e10a13
commit 9ad95eb
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 0 deletions.
diff --git a/...er/src/main/java/com/linkedin/venice/controller/server/ClusterAdminOpsRequestHandler.java b/...er/src/main/java/com/linkedin/venice/controller/server/ClusterAdminOpsRequestHandler.java
@@ -158,6 +158,10 @@ public AdminTopicMetadataGrpcResponse updateAdminOperationProtocolVersion(
     }
 
     long adminOperationProtocolVersion = request.getAdminOperationProtocolVersion();
+    if (adminOperationProtocolVersion == 0 || adminOperationProtocolVersion < -1) {
+      throw new IllegalArgumentException(
+          "Admin operation protocol version is required and must be -1 or greater than 0");
+    }
 
     LOGGER.info(
         "Updating admin operation protocol version for cluster: {} to version: {}",

diff --git a/...rc/test/java/com/linkedin/venice/controller/server/ClusterAdminOpsRequestHandlerTest.java b/...rc/test/java/com/linkedin/venice/controller/server/ClusterAdminOpsRequestHandlerTest.java
@@ -23,6 +23,7 @@
 import com.linkedin.venice.protocols.controller.AdminTopicMetadataGrpcResponse;
 import com.linkedin.venice.protocols.controller.LastSuccessfulAdminCommandExecutionGrpcRequest;
 import com.linkedin.venice.protocols.controller.LastSuccessfulAdminCommandExecutionGrpcResponse;
+import com.linkedin.venice.protocols.controller.UpdateAdminOperationProtocolVersionGrpcRequest;
 import com.linkedin.venice.protocols.controller.UpdateAdminTopicMetadataGrpcRequest;
 import java.util.Collections;
 import java.util.HashMap;
@@ -265,4 +266,48 @@ public void testUpdateAdminTopicMetadataInvalidInputs() {
         exception.getMessage().contains("Updating offsets is not allowed for store-level admin topic metadata"),
         "Actual message: " + exception.getMessage());
   }
+
+  @Test
+  public void testUpdateAdminOperationProtocolVersionSuccess() {
+    String clusterName = "test-cluster";
+    long version = 12345L;
+    UpdateAdminOperationProtocolVersionGrpcRequest request = UpdateAdminOperationProtocolVersionGrpcRequest.newBuilder()
+        .setClusterName(clusterName)
+        .setAdminOperationProtocolVersion(version)
+        .build();
+    AdminTopicMetadataGrpcResponse response = handler.updateAdminOperationProtocolVersion(request);
+
+    assertNotNull(response);
+    assertEquals(response.getMetadata().getClusterName(), clusterName);
+    assertEquals(response.getMetadata().getAdminOperationProtocolVersion(), version);
+  }
+
+  @Test
+  public void testUpdateAdminOperationProtocolVersionInvalidInputs() {
+    String clusterName = "test-cluster";
+    long version = 12345L;
+
+    // No cluster name
+    UpdateAdminOperationProtocolVersionGrpcRequest request1 =
+        UpdateAdminOperationProtocolVersionGrpcRequest.newBuilder()
+            .setClusterName("")
+            .setAdminOperationProtocolVersion(version)
+            .build();
+    Exception exception =
+        expectThrows(IllegalArgumentException.class, () -> handler.updateAdminOperationProtocolVersion(request1));
+    assertTrue(
+        exception.getMessage().contains("Cluster name is required for updating admin operation protocol version"));
+
+    // Invalid version
+    UpdateAdminOperationProtocolVersionGrpcRequest request2 =
+        UpdateAdminOperationProtocolVersionGrpcRequest.newBuilder()
+            .setClusterName(clusterName)
+            .setAdminOperationProtocolVersion(0)
+            .build();
+    exception =
+        expectThrows(IllegalArgumentException.class, () -> handler.updateAdminOperationProtocolVersion(request2));
+    assertTrue(
+        exception.getMessage()
+            .contains("Admin operation protocol version is required and must be -1 or greater than 0"));
+  }
 }