rust: Remove build dependency on protoc
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
force-pushed
the
ver/pregen
branch
3 times, most recently
from
9463bb1 to
3fac02b
Compare
The protobuf project does not publish `protoc` binaries for 32-bit ARM hosts, which complicates our compilation tooling for ARM. This problem can be avoided completely by committing the generated interface bindings so that crates that depend on `linkerd2-proxy-api` don't need any build dependencies. This change removes the `client`, `server`, and `transport` features. Client and server bindings are now always generated for gRPC services. The `transport` feature is removed, since it cannot be optional if the generated code is stored in the repo. We don't want to require tonic's transport feature because it pulls in many dependencies that we don't really need. Signed-off-by: Oliver Gould <ver@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protobuf project does not publish
protocbinaries for 32-bit ARMhosts, which complicates our compilation tooling for ARM. This problem
can be avoided completely by committing the generated interface
bindings so that crates that depend on
linkerd2-proxy-apidon't needany build dependencies.
This change removes the
client,server, andtransportfeatures.Client and server bindings are now always generated for gRPC services.
The
transportfeature is removed, since it cannot be optional if thegenerated code is stored in the repo. We don't want to require tonic's
transport feature because it pulls in many dependencies that we don't
really need.