Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Update build tooling #116

Merged
merged 1 commit into from
May 30, 2022
Merged

dev: Update build tooling #116

merged 1 commit into from
May 30, 2022

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented May 30, 2022

  • Remove the bootstrap Rust test in favor of a gen example. This
    allows us to regenerate Rust bindings without failing a test. This
    tooling now discovers all protobuf files instead of using a hardcoded
    list.
  • Add a tools.go file to express dependencies on the tools needed to
    build the project.
  • just {go-,rs-,}gen-check can be used to regenerate bindings and then
    check whether the generated bindings differ from what is in version
    control.
  • just go-gen no longer uses a hardcoded list of protobuf files.
  • Add just go-mod-tree and go-mod-why utilities to inspect the
    dependency tree (as cargo-tree would).
  • Update the devcontainer configuration so that the vscode-proto3 plugin
    is aware of relative imports.

Signed-off-by: Oliver Gould ver@buoyant.io

@olix0r olix0r force-pushed the ver/gen branch 10 times, most recently from 734310d to 1c5bd78 Compare May 30, 2022 17:44
@olix0r olix0r marked this pull request as ready for review May 30, 2022 17:51
* Remove the `bootstrap` Rust test in favor of a `gen` example. This
  allows us to regenerate Rust bindings without failing a test. This
  tooling now discovers all protobuf files instead of using a hardcoded
  list.
* Add a `tools.go` file to express dependencies on the tools needed to
  build the project.
* `just {go-,rs-,}gen-check` can be used to regenerate bindings and then
  check whether the generated bindings differ from what is in version
  control.
* `just go-gen` no longer uses a hardcoded list of protobuf files.
* Add `just go-mod-tree` and `go-mod-why` utilities to inspect the
  dependency tree (as cargo-tree would).
* Update the devcontainer configuration so that the vscode-proto3 plugin
  is aware of relative imports.
* The CI workflow is split into two language-specific workflows.

Signed-off-by: Oliver Gould <ver@buoyant.io>
@olix0r olix0r merged commit 4b1bef2 into main May 30, 2022
@olix0r olix0r deleted the ver/gen branch May 30, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant