policy: Add support for cluster-scoped default policies #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The policy controller supports the default policies `cluster-authenticated` and `cluster-unauthenticated` but the proxy would error if configured with these policies. In order to use a single policy annotation honored by both the policy controller and proxy, this change adds support for a new configuration, `LINKERD2_POLICY_CLUSTER_NETWORKS`, that allows the proxy to enforce cluster-scoped defaults. When this configuration is not specified, the cluster-scoped defaults are not supported. This default will apply to all ports that are not documented in the pod's spec (i.e. ports not in the `LINKERD2_PROXY_INBOUND_PORTS` configuration).
hawkw
approved these changes
Aug 23, 2021
| detect_timeout: Duration, | ||
| ) -> Result<policy::DefaultPolicy, ParseError> { | ||
| match s { | ||
| "deny" => Ok(policy::DefaultPolicy::Deny), | ||
| "all-authenticated" => Ok(policy::defaults::all_authenticated(detect_timeout).into()), | ||
| "all-unauthenticated" => Ok(policy::defaults::all_unauthenticated(detect_timeout).into()), | ||
|
|
||
| // If cluster networks are configured, support cluster-scoped default policies. | ||
| name if cluster_nets.is_empty() => Err(ParseError::InvalidPortPolicy(name.to_string())), |
There was a problem hiding this comment.
hmm, should there be a separate error case for this? this way, we will log an error that kind of implies "cluster-authenticated" isn't a valid default policy name, but it is a valid policy, it's just not valid in the case that there's no cluster networks.
possibly improving the error message here is not that important, though, since users aren't setting these env vars manually?
There was a problem hiding this comment.
possibly improving the error message here is not that important, though, since users aren't setting these env vars manually?
Correct. Seeing this is basically a programing error: the injector isn't doing the right thing. There's nothing a user could change in their config other than to change/unset the default policy on the pod.
kleimkuhler
approved these changes
Aug 23, 2021
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Aug 26, 2021
This release improves policy handling for HTTP connections so that requests are failed with a 403 Forbidden status (or a PERMISSION_DENIED grpc-status, if appropriate). Inbound metrics now include labels indicating the server and/or authorization used to allow a connection or request to the proxy. Error metrics now include an `unauthorized` error reason for traffic that is denied by policy. Finally, the outbound proxy no longer initializes mTLS or HTTP/2 upgrades when the target proxy is itself. This is done in preparation for changes that will allow the proxy to stop forwarding connections on `localhost` so that servers bound only on the loopback interface are not exposed by Linkerd. --- * build(deps): bump h2 from 0.3.3 to 0.3.4 (linkerd/linkerd2-proxy#1212) * build(deps): bump libc from 0.2.99 to 0.2.100 (linkerd/linkerd2-proxy#1213) * Use `ExtractParam` in transport metrics (linkerd/linkerd2-proxy#1211) * policy: Add support for cluster-scoped default policies (linkerd/linkerd2-proxy#1210) * Expose policy labels on inbound transport metrics (linkerd/linkerd2-proxy#1215) * inbound: Expose permit labels on HTTP metrics (linkerd/linkerd2-proxy#1216) * build(deps): bump tokio from 1.10.0 to 1.10.1 (linkerd/linkerd2-proxy#1218) * build(deps): bump codecov/codecov-action from 2.0.2 to 2.0.3 (linkerd/linkerd2-proxy#1217) * build(deps): bump hyper from 0.14.11 to 0.14.12 (linkerd/linkerd2-proxy#1221) * build(deps): bump bytes from 1.0.1 to 1.1.0 (linkerd/linkerd2-proxy#1222) * inbound: Return HTTP-level authorization errors (linkerd/linkerd2-proxy#1220) * Skip TLS and H2 when target is inbound IP (linkerd/linkerd2-proxy#1219)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Aug 26, 2021
This release improves policy handling for HTTP connections so that requests are failed with a 403 Forbidden status (or a PERMISSION_DENIED grpc-status, if appropriate). Inbound metrics now include labels indicating the server and/or authorization used to allow a connection or request to the proxy. Error metrics now include an `unauthorized` error reason for traffic that is denied by policy. Finally, the outbound proxy no longer initializes mTLS or HTTP/2 upgrades when the target proxy is itself. This is done in preparation for changes that will allow the proxy to stop forwarding connections on `localhost` so that servers bound only on the loopback interface are not exposed by Linkerd. --- * build(deps): bump h2 from 0.3.3 to 0.3.4 (linkerd/linkerd2-proxy#1212) * build(deps): bump libc from 0.2.99 to 0.2.100 (linkerd/linkerd2-proxy#1213) * Use `ExtractParam` in transport metrics (linkerd/linkerd2-proxy#1211) * policy: Add support for cluster-scoped default policies (linkerd/linkerd2-proxy#1210) * Expose policy labels on inbound transport metrics (linkerd/linkerd2-proxy#1215) * inbound: Expose permit labels on HTTP metrics (linkerd/linkerd2-proxy#1216) * build(deps): bump tokio from 1.10.0 to 1.10.1 (linkerd/linkerd2-proxy#1218) * build(deps): bump codecov/codecov-action from 2.0.2 to 2.0.3 (linkerd/linkerd2-proxy#1217) * build(deps): bump hyper from 0.14.11 to 0.14.12 (linkerd/linkerd2-proxy#1221) * build(deps): bump bytes from 1.0.1 to 1.1.0 (linkerd/linkerd2-proxy#1222) * inbound: Return HTTP-level authorization errors (linkerd/linkerd2-proxy#1220) * Skip TLS and H2 when target is inbound IP (linkerd/linkerd2-proxy#1219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy controller supports the default policies
cluster-authenticatedandcluster-unauthenticatedbut the proxywould error if configured with these policies. In order to use a single
policy annotation honored by both the policy controller and proxy, this
change adds support for a new configuration,
LINKERD2_POLICY_CLUSTER_NETWORKS, that allows the proxy to enforcecluster-scoped defaults. When this configuration is not specified, the
cluster-scoped defaults are not supported.
This default will apply to all ports that are not documented in the
pod's spec (i.e. ports not in the
LINKERD2_PROXY_INBOUND_PORTSconfiguration).
This change also updates policy labeling to track server and authz labels
independently so that keys may overlap, as is required by linkerd/linkerd2#6722