policy: use TLS/TCP filters from proxy API response #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
zaharidichev
commented
Nov 21, 2024
Comment on lines
-13
to
18
| tls::Filter::ForbiddenRoute => { | ||
| tls::Filter::Forbidden => { | ||
| return Err(errors::TLSForbiddenRoute.into()); | ||
| } | ||
|
|
||
| tls::Filter::InvalidBackend(message) => { | ||
| tls::Filter::Invalid(message) => { | ||
| return Err(errors::TLSInvalidBackend(message.clone()).into()); |
There was a problem hiding this comment.
We can change the name of these error types to be more generic if we want to. We currently return Invalid only if backends are invalid and Forbidden only if a route is forbidden, so this seems fine as it is for now 🤷
olix0r
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the proxy API dependency to a new version that uses filters to express errors for TLS and TCP routes.
This PR depends on linkerd/linkerd2-proxy-api#405
Signed-off-by: Zahari Dichev zaharidichev@gmail.com