port stack to std::future #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This one was slightly tricker because `tower-util::Ready` now borrows. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
kleimkuhler
reviewed
Apr 23, 2020
olix0r
approved these changes
Apr 23, 2020
kleimkuhler
approved these changes
Apr 23, 2020
hawkw
added a commit
that referenced
this pull request
Apr 24, 2020
This branch ports the `linkerd2-buffer` to use `std::future` and `tokio` 0.2. I've also re-enabled the `push_spawn_buffer` fns in `svc`. Like #486 and #487, this change should be pretty straightforward to read, as it's fairly mechanical in nature. I've basically just changed the code to account for the new APIs. This one might be a _little_ more interesting, since it shows off some of the API differences in `tokio::sync` in 0.2 as well. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch ports the
linkerd2-stackcrate to use Tower 0.3 andstd::futureand tokio 0.2's timers. I've also re-enabled thepush_*methods for layers exported by that crate.This change should be pretty straightforward to read, as it's fairly
mechanical in nature. I've basically just changed the code to account
for the new APIs, but the implementation should be quite similar.