port stack-metrics to std::future #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had forgotten that `linkerd2-stack-metrics` is actually kind of load bearing: the `TrackServiceLayer` is necessary for powering cache eviction as well as being used for debugging. It turns out that we need this to create stacks that work. This branch ports `linkerd2-stack-metrics` to std::future. This change was pretty trivial; I just updated to use the new `tower::Service` trait. I also pruned a bunch of dependencies that this crate wasn't actually using from the Cargo.toml. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
olix0r
approved these changes
May 13, 2020
kleimkuhler
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had forgotten that
linkerd2-stack-metricsis actually kind of loadbearing: the
TrackServiceLayeris necessary for powering cacheeviction as well as being used for debugging. It turns out that we need
this to create stacks that work.
This branch ports
linkerd2-stack-metricsto std::future. This changewas pretty trivial; I just updated to use the new
tower::Servicetrait. I also pruned a bunch of dependencies that this crate wasn't
actually using from the Cargo.toml.
Signed-off-by: Eliza Weisman eliza@buoyant.io