Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linkerd2-proxy-api-resolve to use Tonic #519

Merged
merged 5 commits into from
May 20, 2020

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented May 18, 2020

This branch updates the linkerd2-proxy-api-resolve crate to use
std::future and Tonic. Getting this to work required some upstream
changes to linkerd/linkerd2-proxy-api#39 to pass different feature flags
to Tonic, but the change here is pretty straigntforward.

Depends on #518 and will be rebased onto master-tokio-02
when that branch merges.

@hawkw hawkw requested review from a team, kleimkuhler and olix0r May 18, 2020 23:49
Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to change the base branch before you merge ;)

@hawkw hawkw force-pushed the eliza/0.2-api-resolve branch from 10c9ca1 to 4c49d9d Compare May 19, 2020 20:25
@hawkw hawkw changed the base branch from eliza/0.2-resolve to master-tokio-0.2 May 19, 2020 20:25
Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hawkw added 5 commits May 20, 2020 09:59
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw force-pushed the eliza/0.2-api-resolve branch from 4c49d9d to ff64912 Compare May 20, 2020 17:00
@hawkw hawkw merged commit 17675e7 into master-tokio-0.2 May 20, 2020
@olix0r olix0r deleted the eliza/0.2-api-resolve branch May 25, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants