Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable proxy integration tests #561

Merged
merged 7 commits into from
Jun 14, 2020
Merged

re-enable proxy integration tests #561

merged 7 commits into from
Jun 14, 2020

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Jun 12, 2020

This branch re-enables all the proxy integration tests that hadn't
already been turned back on.

It turns out that almost everything just works!

Depends on #560

Signed-off-by: Eliza Weisman eliza@buoyant.io

@olix0r olix0r requested a review from kleimkuhler June 12, 2020 18:34
Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Looks like changes #560 were included in this just a heads up.

@hawkw
Copy link
Contributor Author

hawkw commented Jun 12, 2020

Looks good! Looks like changes #560 were included in this just a heads up.

Yup, the commit message notes that this depends on that branch :)

hawkw added 3 commits June 12, 2020 13:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Eliza Weisman <eliza@buoyant.io>

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
The way Hyepr handles disconnections has changed, so we no logner see
this errno. This is actually more consistent with the way clean
disconnections are handled for raw TCP traffic, anyway!

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw force-pushed the eliza/0.2-tests branch from 49d5f2b to 8c9eda0 Compare June 12, 2020 20:48
hawkw and others added 4 commits June 12, 2020 14:12
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
whoops --- `Vec::clear` sets the length to 0, so no bytes are read into
the buffer. fixed this by just allocating a new vec like the tests used
to do, it's fine, they're just tests.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw merged commit e42d9bd into master-tokio-0.2 Jun 14, 2020
@olix0r olix0r deleted the eliza/0.2-tests branch May 25, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants