Skip to content

Commit

Permalink
Make logHTTPHeaders optional (#12747)
Browse files Browse the repository at this point in the history
The `proxy.logHTTPHeaders` Helm variable supports two values: "insecure" and "off".  However, if this value is absent entirely, validation will fail because it it not one of the supported values.  This can cause issues with backwards compatibility.

We make this value optional by adding "" as a legal value during validation.  Leaving this value unset is equivalent to "off" which is the default value.

Signed-off-by: Alex Leong <alex@buoyant.io>
  • Loading branch information
adleong authored Jun 21, 2024
1 parent 1785592 commit 010f15f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charts/partials/templates/_proxy.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{ if and .Values.proxy.nativeSidecar .Values.proxy.waitBeforeExitSeconds }}
{{ fail "proxy.nativeSidecar and waitBeforeExitSeconds cannot be used simultaneously" }}
{{- end }}
{{- if not (has .Values.proxy.logHTTPHeaders (list "insecure" "off")) }}
{{- if not (has .Values.proxy.logHTTPHeaders (list "insecure" "off" "")) }}
{{- fail "logHTTPHeaders must be one of: insecure | off" }}
{{- end }}
{{- $trustDomain := (.Values.identityTrustDomain | default .Values.clusterDomain) -}}
Expand Down

0 comments on commit 010f15f

Please sign in to comment.