Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pathPrefix from the dashboard code #2254

Closed
rmars opened this issue Feb 11, 2019 · 2 comments
Closed

Remove pathPrefix from the dashboard code #2254

rmars opened this issue Feb 11, 2019 · 2 comments
Labels
area/web

Comments

@rmars
Copy link

rmars commented Feb 11, 2019

In #2052 we moved from using the kubernetes service proxy to port forwarding. This means we no longer need to support pathPrefix from the dashboard. We should remove it as it complicates our link code unnecessarily
@rmars rmars added the area/web label Feb 11, 2019
@klingerf
Copy link
Member

Totally agree! I think this is a dupe of #2057.

@rmars
Copy link
Author

rmars commented Feb 11, 2019

ahhhhh I was searching for "pathPrefix" under issues and couldn't find it. I'll close this then.

@rmars rmars closed this as completed Feb 11, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klingerf @rmars