Setup port-forwarding for linkerd dashboard command #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah, now that's an awesome PR. |
|
Note that there's still a lot of code in the |
|
@klingerf I'm totally behind removing support for viewing the dashboard it via |
siggy
reviewed
Jan 9, 2019
pkg/k8s/portforward.go
Outdated
| ports := []string{fmt.Sprintf("%d:%d", pf.localPort, pf.remotePort)} | ||
| dialer := spdy.NewDialer(upgrader, &http.Client{Transport: transport}, pf.method, pf.url) | ||
|
|
||
| fw, err := portforward.New(dialer, ports, pf.stopCh, pf.readyCh, ioutil.Discard, ioutil.Discard) |
There was a problem hiding this comment.
consider os.Stdout, os.Stderr, perhaps when verbose is enabled?
There was a problem hiding this comment.
Great idea! Have added that in the latest commit.
siggy
approved these changes
Jan 10, 2019
| ports := []string{fmt.Sprintf("%d:%d", pf.localPort, pf.remotePort)} | ||
| dialer := spdy.NewDialer(upgrader, &http.Client{Transport: transport}, pf.method, pf.url) | ||
|
|
||
| fw, err := portforward.New(dialer, ports, pf.stopCh, pf.readyCh, ioutil.Discard, ioutil.Discard) | ||
| fw, err := portforward.New(dialer, ports, pf.stopCh, pf.readyCh, out, errOut) |
There was a problem hiding this comment.
nice!
Forwarding from 127.0.0.1:51328 -> 8084
Forwarding from [::1]:51328 -> 8084
Linkerd dashboard available at:
http://127.0.0.1:51328
Grafana dashboard available at:
http://127.0.0.1:51328/grafana
Handling connection for 51328
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
klingerf
force-pushed
the
kl/port-forward
branch
from
8e10e3b
to
cfba841
Compare
codeman9
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Jan 11, 2019
* Setup port-forwarding for linkerd dashboard command * Output port-forward logs when --verbose flag is set Signed-off-by: Kevin Lingerfelt <kl@buoyant.io> Signed-off-by: Cody Vandermyn <cody.vandermyn@nordstrom.com>
codeman9
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Jan 11, 2019
* Setup port-forwarding for linkerd dashboard command * Output port-forward logs when --verbose flag is set Signed-off-by: Kevin Lingerfelt <kl@buoyant.io> Signed-off-by: Cody Vandermyn <cody.vandermyn@nordstrom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch switches the
linkerd dashboardcommand from using the kubernetes service proxy to access the web UI, to instead using port-forward to access the web pod directly. This simplifies the URLs displayed in the dashboard, and it removes our direct dependency on "k8s.io/kubernetes" 🎉As part of this change, I fixed a bug with
linkerd dashboard, where the proxy would not start until after the dashboard had been successfully loaded in a browser (relates to #2047). And I've updated the integration tests to use port-forwarding instead of proxying to access pods running in the test environment.Fixes #1696.